Make Windows service uninstall idempotent

Treat sc.exe delete error 1060 as success when the service is
already absent so repeated uninstalls do not fail.

Signed-off-by: Bryan Frimin <bryan@probo.com>
This commit is contained in:
Bryan Frimin
2026-05-26 09:34:51 -07:00
parent d310886560
commit 27cccd33aa
2 changed files with 30 additions and 1 deletions

View File

@@ -67,7 +67,12 @@ func Uninstall(cfg Config) error {
name := DefaultWindowsName
_ = exec.Command("sc.exe", "stop", name).Run()
if out, err := exec.Command("sc.exe", "delete", name).CombinedOutput(); err != nil {
return fmt.Errorf("cannot run sc.exe delete: %w: %s", err, strings.TrimSpace(string(out)))
msg := strings.TrimSpace(string(out))
if isWindowsServiceMissing(msg) {
return nil
}
return fmt.Errorf("cannot run sc.exe delete: %w: %s", err, msg)
}
return nil
}