Remove prettier in favor of @stylistic/eslint-plugin

Signed-off-by: Émile Ré <emile@getprobo.com>
This commit is contained in:
Émile Ré
2026-01-20 12:13:07 +04:00
parent c24726b481
commit 27428377c6
16 changed files with 266 additions and 450 deletions

View File

@@ -5,16 +5,12 @@
"main": "./src/index.ts",
"scripts": {
"test": "vitest run",
"test:watch": "vitest",
"format": "prettier --write ./src"
"test:watch": "vitest"
},
"prettier": "@probo/prettier",
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {
"@probo/prettier": "1.0.0",
"prettier": "^3.5.3",
"typescript": "^5.8.3",
"vitest": "^3.1.3"
}

View File

@@ -3,141 +3,141 @@ import globals from "globals";
import reactHooks from "eslint-plugin-react-hooks";
import tseslint from "typescript-eslint";
import stylistic from "@stylistic/eslint-plugin";
import prettier from "eslint-plugin-prettier";
import prettierConfig from "eslint-config-prettier";
/**
* Base ESLint configuration with strict and stylistic rules
*/
export function createConfig({
files = ["**/*.{ts,tsx}"],
languageOptions = {},
react = false,
project = true,
tsconfigRootDir,
files = ["**/*.{ts,tsx}"],
languageOptions = {},
react = false,
project = true,
tsconfigRootDir,
} = {}) {
const configs = [
{ ignores: ["dist", "node_modules", "**/*.d.ts"] },
js.configs.recommended,
...tseslint.configs.recommendedTypeChecked,
...tseslint.configs.stylisticTypeChecked,
{
files,
languageOptions: (() => {
const mergedGlobals = {
...globals.node,
...globals.es2021,
...(languageOptions.globals || {}),
};
const mergedParserOptions = {
project,
...(tsconfigRootDir && { tsconfigRootDir }),
...(languageOptions.parserOptions || {}),
};
const otherLanguageOptions = Object.fromEntries(
Object.entries(languageOptions).filter(([key]) => key !== "globals" && key !== "parserOptions"),
);
const configs = [
{ ignores: ["dist", "node_modules", "**/*.d.ts"] },
js.configs.recommended,
...tseslint.configs.recommendedTypeChecked,
{
files,
languageOptions: (() => {
const mergedGlobals = {
...globals.node,
...globals.es2021,
...(languageOptions.globals || {}),
};
const mergedParserOptions = {
project,
...(tsconfigRootDir && { tsconfigRootDir }),
...(languageOptions.parserOptions || {}),
};
const otherLanguageOptions = Object.fromEntries(
Object.entries(languageOptions).filter(
([key]) => key !== "globals" && key !== "parserOptions",
),
);
return {
ecmaVersion: 2020,
sourceType: "module",
globals: mergedGlobals,
parserOptions: mergedParserOptions,
...otherLanguageOptions,
};
})(),
plugins: {
"@stylistic": stylistic,
prettier,
},
rules: {
// Prettier integration
"prettier/prettier": "error",
return {
ecmaVersion: 2020,
sourceType: "module",
globals: mergedGlobals,
parserOptions: mergedParserOptions,
...otherLanguageOptions,
};
})(),
plugins: {
"@stylistic": stylistic,
},
rules: {
// TypeScript strict rules
"@typescript-eslint/no-unused-vars": [
"error",
{
argsIgnorePattern: "^_",
varsIgnorePattern: "^_",
},
],
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/no-explicit-any": "warn",
"@typescript-eslint/no-floating-promises": "error",
"@typescript-eslint/no-misused-promises": "error",
"@typescript-eslint/await-thenable": "error",
"@typescript-eslint/no-unnecessary-type-assertion": "error",
// TypeScript strict rules
"@typescript-eslint/no-unused-vars": [
"error",
{
argsIgnorePattern: "^_",
varsIgnorePattern: "^_",
},
],
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/no-explicit-any": "warn",
"@typescript-eslint/no-floating-promises": "error",
"@typescript-eslint/no-misused-promises": "error",
"@typescript-eslint/await-thenable": "error",
"@typescript-eslint/no-unnecessary-type-assertion": "error",
// Stylistic rules
"@stylistic/quotes": ["error", "double", { avoidEscape: true }],
"@stylistic/semi": ["error", "always"],
"@stylistic/comma-dangle": ["error", "always-multiline"],
"@stylistic/indent": ["error", 2, { SwitchCase: 1 }],
"@stylistic/object-curly-spacing": ["error", "always"],
"@stylistic/array-bracket-spacing": ["error", "never"],
"@stylistic/comma-spacing": ["error", { before: false, after: true }],
"@stylistic/key-spacing": [
"error",
{ beforeColon: false, afterColon: true },
],
"@stylistic/space-before-blocks": ["error", "always"],
"@stylistic/space-before-function-paren": [
"error",
{ anonymous: "always", named: "never", asyncArrow: "always" },
],
"@stylistic/space-infix-ops": "error",
"@stylistic/arrow-spacing": ["error", { before: true, after: true }],
"@stylistic/no-trailing-spaces": "error",
"@stylistic/eol-last": ["error", "always"],
"@stylistic/max-len": [
"warn",
{ code: 120, ignoreUrls: true, ignoreStrings: true },
],
},
},
];
// Stylistic rules
"@stylistic/quotes": ["error", "double", { avoidEscape: true }],
"@stylistic/semi": ["error", "always"],
"@stylistic/comma-dangle": ["error", "always-multiline"],
"@stylistic/indent": ["error", 4, { SwitchCase: 1 }],
"@stylistic/object-curly-spacing": ["error", "always"],
"@stylistic/array-bracket-spacing": ["error", "never"],
"@stylistic/comma-spacing": ["error", { before: false, after: true }],
"@stylistic/key-spacing": ["error", { beforeColon: false, afterColon: true }],
"@stylistic/space-before-blocks": ["error", "always"],
"@stylistic/space-before-function-paren": [
"error",
{ anonymous: "always", named: "never", asyncArrow: "always" },
],
"@stylistic/space-infix-ops": "error",
"@stylistic/arrow-spacing": ["error", { before: true, after: true }],
"@stylistic/no-trailing-spaces": "error",
"@stylistic/eol-last": ["error", "always"],
"@stylistic/max-len": ["warn", { code: 120, ignoreUrls: true, ignoreStrings: true }],
},
},
prettierConfig,
];
if (react) {
configs.push({
files,
plugins: {
"react-hooks": reactHooks,
},
rules: {
...reactHooks.configs.recommended.rules,
},
});
}
if (react) {
configs.push({
files,
plugins: {
"react-hooks": reactHooks,
},
rules: {
...reactHooks.configs.recommended.rules,
},
});
}
return configs;
return configs;
}
/**
* Browser/React configuration
*/
export function browser(project = true, tsconfigRootDir) {
return createConfig({
files: ["**/*.{ts,tsx}"],
languageOptions: {
globals: {
...globals.browser,
},
},
react: true,
project,
tsconfigRootDir,
});
return createConfig({
files: ["**/*.{ts,tsx}"],
languageOptions: {
globals: {
...globals.browser,
},
},
react: true,
project,
tsconfigRootDir,
});
}
/**
* Node.js configuration
*/
export function node(project = true, tsconfigRootDir) {
return createConfig({
files: ["**/*.{ts,tsx}"],
languageOptions: {
globals: {
...globals.node,
},
},
react: false,
project,
tsconfigRootDir,
});
return createConfig({
files: ["**/*.{ts,tsx}"],
languageOptions: {
globals: {
...globals.node,
},
},
react: false,
project,
tsconfigRootDir,
});
}

View File

@@ -1,25 +1,20 @@
{
"name": "@probo/eslint-config",
"version": "1.0.0",
"private": true,
"description": "Shared ESLint configuration for Probo monorepo",
"main": "eslint.config.mjs",
"type": "module",
"scripts": {},
"keywords": [],
"author": "",
"license": "ISC",
"dependencies": {
"@eslint/js": "^9.25.0",
"@stylistic/eslint-plugin": "^4.2.0",
"eslint-config-prettier": "^9.1.0",
"eslint-plugin-prettier": "^5.2.1",
"eslint-plugin-react-hooks": "^5.2.0",
"globals": "^16.0.0",
"typescript-eslint": "^8.30.1"
},
"peerDependencies": {
"eslint": "^9.25.0",
"prettier": "^3.5.3"
}
"name": "@probo/eslint-config",
"version": "1.0.0",
"private": true,
"description": "Shared ESLint configuration for Probo monorepo",
"main": "eslint.config.mjs",
"type": "module",
"scripts": {},
"keywords": [],
"author": "",
"license": "ISC",
"dependencies": {
"@eslint/js": "^9.25.0",
"@stylistic/eslint-plugin": "^4.2.0",
"eslint": "^9.39.2",
"eslint-plugin-react-hooks": "^5.2.0",
"globals": "^16.0.0",
"typescript-eslint": "^8.30.1"
}
}

View File

@@ -5,16 +5,12 @@
"main": "./src/index.ts",
"scripts": {
"test": "vitest run",
"test:watch": "vitest",
"format": "prettier --write ./src"
"test:watch": "vitest"
},
"prettier": "@probo/prettier",
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {
"@probo/prettier": "1.0.0",
"prettier": "^3.5.3",
"typescript": "^5.8.3",
"vitest": "^3.1.3"
},

View File

@@ -1,21 +1,17 @@
{
"name": "@probo/hooks",
"version": "1.0.0",
"description": "",
"main": "./src/index.ts",
"scripts": {
"test": "vitest run",
"test:watch": "vitest",
"format": "prettier --write ./src"
},
"prettier": "@probo/prettier",
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {
"@probo/prettier": "1.0.0",
"prettier": "^3.5.3",
"typescript": "^5.8.3",
"vitest": "^3.1.3"
}
"name": "@probo/hooks",
"version": "1.0.0",
"description": "",
"main": "./src/index.ts",
"scripts": {
"test": "vitest run",
"test:watch": "vitest"
},
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {
"typescript": "^5.8.3",
"vitest": "^3.1.3"
}
}

View File

@@ -1,14 +0,0 @@
{
"name": "@probo/prettier",
"private": true,
"version": "1.0.0",
"description": "Shared Prettier configuration for Probo monorepo",
"main": "prettier.config.js",
"scripts": {},
"keywords": [],
"author": "",
"license": "ISC",
"peerDependencies": {
"prettier": "^3.5.3"
}
}

View File

@@ -1,14 +0,0 @@
module.exports = {
tabWidth: 2,
useTabs: false,
semi: true, // Add semicolons
singleQuote: false, // Use double quotes (matches @stylistic/quotes)
quoteProps: "as-needed",
trailingComma: "all", // Trailing commas (matches @stylistic/comma-dangle)
bracketSpacing: true, // { foo: bar } not {foo: bar}
arrowParens: "always", // (x) => x not x => x
endOfLine: "lf", // Unix line endings
printWidth: 120, // Max line length (matches @stylistic/max-len)
proseWrap: "preserve",
bracketSameLine: false,
};

View File

@@ -1,13 +1,12 @@
{
"name": "@probo/react-lazy",
"version": "1.0.0",
"description": "Enhanced React lazy loading with retries and error handling",
"private": true,
"type": "module",
"main": "src/index.ts",
"scripts": {},
"prettier": "@probo/prettier",
"peerDependencies": {
"react": ">18.0.0"
}
"name": "@probo/react-lazy",
"version": "1.0.0",
"description": "Enhanced React lazy loading with retries and error handling",
"private": true,
"type": "module",
"main": "src/index.ts",
"scripts": {},
"peerDependencies": {
"react": ">18.0.0"
}
}

View File

@@ -1,31 +1,27 @@
{
"name": "@probo/relay",
"version": "1.0.0",
"description": "",
"type": "module",
"main": "./src/index.ts",
"scripts": {
"test": "vitest run",
"test:watch": "vitest",
"format": "prettier --write ./src"
},
"prettier": "@probo/prettier",
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {
"@probo/prettier": "1.0.0",
"prettier": "^3.5.3",
"typescript": "^5.8.3",
"vitest": "^3.1.3"
},
"peerDependencies": {
"react": "^19.2.1",
"react-relay": "^19.0.0",
"react-router": "^7.10.0",
"relay-runtime": "^19.0.0"
},
"dependencies": {
"graphql": "^16.12.0"
}
"name": "@probo/relay",
"version": "1.0.0",
"description": "",
"type": "module",
"main": "./src/index.ts",
"scripts": {
"test": "vitest run",
"test:watch": "vitest"
},
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {
"typescript": "^5.8.3",
"vitest": "^3.1.3"
},
"peerDependencies": {
"react": "^19.2.1",
"react-relay": "^19.0.0",
"react-router": "^7.10.0",
"relay-runtime": "^19.0.0"
},
"dependencies": {
"graphql": "^16.12.0"
}
}

View File

@@ -5,16 +5,12 @@
"main": "./src/index.ts",
"scripts": {
"test": "vitest run",
"test:watch": "vitest",
"format": "prettier --write ./src"
"test:watch": "vitest"
},
"prettier": "@probo/prettier",
"keywords": [],
"author": "",
"license": "ISC",
"devDependencies": {
"@probo/prettier": "1.0.0",
"prettier": "^3.5.3",
"typescript": "^5.8.3",
"vitest": "^3.1.3"
},

View File

@@ -1,76 +1,73 @@
{
"name": "@probo/ui",
"version": "1.0.0",
"private": true,
"type": "module",
"main": "src/index.ts",
"scripts": {
"lint": "eslint .",
"dev": "storybook dev -p 6006 --no-open",
"check": "tsc --noEmit -p tsconfig.app.json",
"icons": "bun run src/Atoms/Icons/generator.ts"
},
"prettier": "@probo/prettier",
"dependencies": {
"@ariakit/react": "^0.4.17",
"@probo/helpers": "1.0.0",
"@probo/i18n": "1.0.0",
"@radix-ui/react-alert-dialog": "^1.1.15",
"@radix-ui/react-dropdown-menu": "^2.1.16",
"@radix-ui/react-label": "^2.1.8",
"@radix-ui/react-popover": "^1.1.15",
"@radix-ui/react-portal": "^1.1.10",
"@radix-ui/react-scroll-area": "^1.2.10",
"@radix-ui/react-select": "^2.2.6",
"@radix-ui/react-tabs": "^1.1.13",
"clsx": "^2.1.1",
"cmdk": "^1.1.1",
"react-dropzone": "^14.3.8",
"react-intersection-observer": "^9.16.0",
"react-markdown": "^10.1.0",
"rehype-raw": "^7.0.0",
"remark-gfm": "^4.0.1",
"tailwind-variants": "^1.0.0",
"tailwindcss": "^4.1.7",
"tw-animate-css": "^1.3.0",
"zustand": "^5.0.4"
},
"devDependencies": {
"@chromatic-com/storybook": "^3.2.6",
"@probo/eslint-config": "1.0.0",
"@probo/prettier": "1.0.0",
"@rollup/pluginutils": "^5.1.4",
"@storybook/addon-essentials": "^8.6.13",
"@storybook/blocks": "^8.6.13",
"@storybook/experimental-addon-test": "^8.6.13",
"@storybook/react": "^8.6.13",
"@storybook/react-vite": "^8.6.13",
"@storybook/test": "^8.6.13",
"@tailwindcss/typography": "^0.5.16",
"@tailwindcss/vite": "^4.1.17",
"@types/react": "^19.1.2",
"@types/react-dom": "^19.1.2",
"@vitejs/plugin-react": "^4.4.1",
"@vitest/browser": "^3.1.3",
"@vitest/coverage-v8": "^3.1.3",
"eslint": "^9.25.0",
"playwright": "^1.55.1",
"prettier": "^3.5.3",
"react": "^19.1.0",
"react-docgen": "^7.1.1",
"react-dom": "^19.1.0",
"react-router": "^7.12.0",
"storybook": "^8.6.15",
"typescript": "~5.8.3",
"vite": "^6.4.1",
"vitest": "^3.1.3"
},
"peerDependencies": {
"react": "^19.1.0",
"react-dom": "^19.1.0",
"react-router": "^7.12.0"
},
"volta": {
"node": "24.4.0"
}
"name": "@probo/ui",
"version": "1.0.0",
"private": true,
"type": "module",
"main": "src/index.ts",
"scripts": {
"lint": "eslint .",
"dev": "storybook dev -p 6006 --no-open",
"check": "tsc --noEmit -p tsconfig.app.json",
"icons": "bun run src/Atoms/Icons/generator.ts"
},
"dependencies": {
"@ariakit/react": "^0.4.17",
"@probo/helpers": "1.0.0",
"@probo/i18n": "1.0.0",
"@radix-ui/react-alert-dialog": "^1.1.15",
"@radix-ui/react-dropdown-menu": "^2.1.16",
"@radix-ui/react-label": "^2.1.8",
"@radix-ui/react-popover": "^1.1.15",
"@radix-ui/react-portal": "^1.1.10",
"@radix-ui/react-scroll-area": "^1.2.10",
"@radix-ui/react-select": "^2.2.6",
"@radix-ui/react-tabs": "^1.1.13",
"clsx": "^2.1.1",
"cmdk": "^1.1.1",
"react-dropzone": "^14.3.8",
"react-intersection-observer": "^9.16.0",
"react-markdown": "^10.1.0",
"rehype-raw": "^7.0.0",
"remark-gfm": "^4.0.1",
"tailwind-variants": "^1.0.0",
"tailwindcss": "^4.1.7",
"tw-animate-css": "^1.3.0",
"zustand": "^5.0.4"
},
"devDependencies": {
"@chromatic-com/storybook": "^3.2.6",
"@probo/eslint-config": "1.0.0",
"@rollup/pluginutils": "^5.1.4",
"@storybook/addon-essentials": "^8.6.13",
"@storybook/blocks": "^8.6.13",
"@storybook/experimental-addon-test": "^8.6.13",
"@storybook/react": "^8.6.13",
"@storybook/react-vite": "^8.6.13",
"@storybook/test": "^8.6.13",
"@tailwindcss/typography": "^0.5.16",
"@tailwindcss/vite": "^4.1.17",
"@types/react": "^19.1.2",
"@types/react-dom": "^19.1.2",
"@vitejs/plugin-react": "^4.4.1",
"@vitest/browser": "^3.1.3",
"@vitest/coverage-v8": "^3.1.3",
"eslint": "^9.25.0",
"playwright": "^1.55.1",
"react": "^19.1.0",
"react-docgen": "^7.1.1",
"react-dom": "^19.1.0",
"react-router": "^7.12.0",
"storybook": "^8.6.15",
"typescript": "~5.8.3",
"vite": "^6.4.1",
"vitest": "^3.1.3"
},
"peerDependencies": {
"react": "^19.1.0",
"react-dom": "^19.1.0",
"react-router": "^7.12.0"
},
"volta": {
"node": "24.4.0"
}
}