Leave Segment members' active status unknown
Segment's /users API exposes no active/suspended field, so reporting every confirmed member as Active=true fabricated a status the source never provides, contrary to the AccountRecord contract (nil = no explicit signal). Leave Active nil for confirmed members; pending invites keep Active=false, which is a real signal from /invites. Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
@@ -123,13 +123,15 @@ func (d *SegmentDriver) ListAccounts(ctx context.Context) ([]AccountRecord, erro
|
||||
}
|
||||
|
||||
roles, isAdmin := segmentRolesAndAdmin(perms)
|
||||
active := true
|
||||
|
||||
// Segment's user API exposes no active/suspended status field, so
|
||||
// leave Active nil (unknown) rather than fabricate a value, per the
|
||||
// AccountRecord contract.
|
||||
records = append(records, AccountRecord{
|
||||
Email: email,
|
||||
FullName: segmentFullName(u.Name, email),
|
||||
Roles: roles,
|
||||
Active: &active,
|
||||
Active: nil,
|
||||
IsAdmin: isAdmin,
|
||||
MFAStatus: coredata.MFAStatusUnknown,
|
||||
AuthMethod: coredata.AccessReviewEntryAuthMethodUnknown,
|
||||
|
||||
Reference in New Issue
Block a user