rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused request param from InitiateWithState

Browse Source 
The r *http.Request parameter was not read inside
InitiateWithState — all test call sites passed nil.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
This commit is contained in:
Aurélien Sibiril
2026-04-10 10:12:38 +02:00
parent 816b9300ed
commit 1def3a4136
2 changed files with 1 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/connector/oauth2_test.go
View File

@@ -278,7 +278,6 @@ func TestInitiateWithState_Scopes(t *testing.T) {
context.Background(),
OAuth2State{OrganizationID: orgID.String(), Provider: "TEST"},
InitiateOptions{Scopes: []string{"read:user", "write:user"}},
nil,
)
require.NoError(t, err)
@@ -303,7 +302,6 @@ func TestInitiateWithState_Scopes(t *testing.T) {
context.Background(),
OAuth2State{OrganizationID: orgID.String(), Provider: "TEST"},
InitiateOptions{},
nil,
)
require.NoError(t, err)
@@ -332,7 +330,6 @@ func TestInitiateWithState_Scopes(t *testing.T) {
Scopes: []string{"read:user"},
IncludeGrantedScopes: true,
},
nil,
)
require.NoError(t, err)
@@ -361,7 +358,6 @@ func TestInitiateWithState_Scopes(t *testing.T) {
Scopes: []string{"read:user"},
IncludeGrantedScopes: true,
},
nil,
)
require.NoError(t, err)
@@ -387,7 +383,6 @@ func TestInitiateWithState_Scopes(t *testing.T) {
context.Background(),
OAuth2State{OrganizationID: orgID.String(), Provider: "TEST"},
InitiateOptions{Scopes: []string{"read:user"}},
nil,
)
require.NoError(t, err)
@@ -420,7 +415,6 @@ func TestInitiateWithState_Scopes(t *testing.T) {
Scopes: []string{"read:user"},
IncludeGrantedScopes: true,
},
nil,
)
require.NoError(t, err)
@@ -455,7 +449,6 @@ func TestInitiateWithState_Scopes(t *testing.T) {
Scopes: []string{"read:user"},
IncludeGrantedScopes: false, // first install, no existing grant
},
nil,
)
require.NoError(t, err)
@@ -489,7 +482,6 @@ func TestInitiateWithState_Scopes(t *testing.T) {
Scopes: []string{"read:user"},
IncludeGrantedScopes: true, // caller requested, but provider does not support
},
nil,
)
require.NoError(t, err)