rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use new coredata error pattern

Browse Source 
Signed-off-by: Bryan Frimin <bryan@getprobo.com>
This commit is contained in:
Bryan Frimin
2026-01-05 19:48:27 +01:00
parent ff2c2a5974
commit 1cf4d6125a
5 changed files with 17 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
pkg/coredata/data_protection_impact_assessment.go
View File

@@ -27,20 +27,6 @@ import (
"go.probo.inc/probo/pkg/page"
)
type ErrDataProtectionImpactAssessmentNotFound struct {
Identifier string
}
func (e ErrDataProtectionImpactAssessmentNotFound) Error() string {
return fmt.Sprintf("data protection impact assessment not found: %q", e.Identifier)
}
type ErrNoDataProtectionImpactAssessmentsFound struct{}
func (e ErrNoDataProtectionImpactAssessmentsFound) Error() string {
return "no data protection impact assessments found"
}
type (
DataProtectionImpactAssessment struct {
ID gid.GID `db:"id"`
@@ -263,8 +249,9 @@ LIMIT 1;
result, err := pgx.CollectExactlyOneRow(rows, pgx.RowToStructByName[DataProtectionImpactAssessment])
if err != nil {
if errors.Is(err, pgx.ErrNoRows) {
return &ErrDataProtectionImpactAssessmentNotFound{Identifier: dpiaID.String()}
return ErrResourceNotFound
}
return fmt.Errorf("cannot collect data protection impact assessment: %w", err)
}
@@ -314,8 +301,9 @@ LIMIT 1;
result, err := pgx.CollectExactlyOneRow(rows, pgx.RowToStructByName[DataProtectionImpactAssessment])
if err != nil {
if errors.Is(err, pgx.ErrNoRows) {
return &ErrDataProtectionImpactAssessmentNotFound{Identifier: processingActivityID.String()}
return ErrResourceNotFound
}
return fmt.Errorf("cannot collect data protection impact assessment: %w", err)
}

18
pkg/coredata/transfer_impact_assessment.go
View File

@@ -27,20 +27,6 @@ import (
"go.probo.inc/probo/pkg/page"
)
type ErrTransferImpactAssessmentNotFound struct {
Identifier string
}
func (e ErrTransferImpactAssessmentNotFound) Error() string {
return fmt.Sprintf("transfer impact assessment not found: %q", e.Identifier)
}
type ErrNoTransferImpactAssessmentsFound struct{}
func (e ErrNoTransferImpactAssessmentsFound) Error() string {
return "no transfer impact assessments found"
}
type (
TransferImpactAssessment struct {
ID gid.GID `db:"id"`
@@ -262,7 +248,7 @@ LIMIT 1;
result, err := pgx.CollectExactlyOneRow(rows, pgx.RowToStructByName[TransferImpactAssessment])
if err != nil {
if errors.Is(err, pgx.ErrNoRows) {
return &ErrTransferImpactAssessmentNotFound{Identifier: tiaID.String()}
return ErrResourceNotFound
}
return fmt.Errorf("cannot collect transfer impact assessment: %w", err)
}
@@ -313,7 +299,7 @@ LIMIT 1;
result, err := pgx.CollectExactlyOneRow(rows, pgx.RowToStructByName[TransferImpactAssessment])
if err != nil {
if errors.Is(err, pgx.ErrNoRows) {
return &ErrTransferImpactAssessmentNotFound{Identifier: processingActivityID.String()}
return ErrResourceNotFound
}
return fmt.Errorf("cannot collect transfer impact assessment: %w", err)
}