Fix multiline function call style violations

Expand mixed inline/multiline function calls so each argument
is on its own line, matching the one-argument-per-line rule.

Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>

pkg/iam/policy/evaluator_test.go

@@ -21,7 +21,9 @@ import (
 func TestEvaluator_Evaluate_AllowDecision(t *testing.T) {
 	evaluator := NewEvaluator()
 
-	policy := NewPolicy("test", "Test Policy",
+	policy := NewPolicy(
+		"test",
+		"Test Policy",
 		Allow("iam:identity:get", "iam:identity:update"),
 	)
 
@@ -68,7 +70,9 @@ func TestEvaluator_Evaluate_AllowDecision(t *testing.T) {
 func TestEvaluator_Evaluate_DenyDecision(t *testing.T) {
 	evaluator := NewEvaluator()
 
-	policy := NewPolicy("test", "Test Policy",
+	policy := NewPolicy(
+		"test",
+		"Test Policy",
 		Allow("iam:*:*"),
 		Deny("iam:organization:delete").WithSID("deny-org-delete"),
 	)
@@ -112,10 +116,14 @@ func TestEvaluator_Evaluate_DenyWinsOverAllow(t *testing.T) {
 	evaluator := NewEvaluator()
 
 	// Two policies: one allows, one denies the same action
-	allowPolicy := NewPolicy("allow", "Allow Policy",
+	allowPolicy := NewPolicy(
+		"allow",
+		"Allow Policy",
 		Allow("iam:organization:delete"),
 	)
-	denyPolicy := NewPolicy("deny", "Deny Policy",
+	denyPolicy := NewPolicy(
+		"deny",
+		"Deny Policy",
 		Deny("iam:organization:delete"),
 	)
 
@@ -147,7 +155,9 @@ func TestEvaluator_Evaluate_WithConditions(t *testing.T) {
 	evaluator := NewEvaluator()
 
 	// Policy that only allows users to update their own identity
-	selfManagePolicy := NewPolicy("self-manage", "Self Manage",
+	selfManagePolicy := NewPolicy(
+		"self-manage",
+		"Self Manage",
 		Allow("iam:identity:update").
 			When(Equals("principal.id", "resource.id")),
 	)
@@ -194,7 +204,9 @@ func TestEvaluator_Evaluate_MultipleConditions(t *testing.T) {
 	evaluator := NewEvaluator()
 
 	// Policy that requires both conditions to be met
-	policy := NewPolicy("test", "Test",
+	policy := NewPolicy(
+		"test",
+		"Test",
 		Allow("documents:document:update").
 			When(
 				Equals("principal.id", "resource.owner_id"),
@@ -358,7 +370,9 @@ func TestEvaluator_Evaluate_NilPolicies(t *testing.T) {
 func TestEvaluator_Evaluate_MatchedStatementAndPolicy(t *testing.T) {
 	evaluator := NewEvaluator()
 
-	policy := NewPolicy("test-policy", "Test Policy",
+	policy := NewPolicy(
+		"test-policy",
+		"Test Policy",
 		Allow("iam:identity:get").WithSID("allow-get"),
 		Deny("iam:identity:delete").WithSID("deny-delete"),
 	)

pkg/iam/policy/example_test.go

@@ -22,24 +22,32 @@ import (
 
 func Example_definingPolicies() {
 	// Define a viewer policy - can read everything
-	viewerPolicy := policy.NewPolicy("viewer", "Viewer Policy",
+	viewerPolicy := policy.NewPolicy(
+		"viewer",
+		"Viewer Policy",
 		policy.Allow("*:*:read", "*:*:list"),
 	).WithDescription("Read-only access to all resources")
 
 	// Define an admin policy - can do everything except delete organization
-	adminPolicy := policy.NewPolicy("admin", "Admin Policy",
+	adminPolicy := policy.NewPolicy(
+		"admin",
+		"Admin Policy",
 		policy.Allow("*"),
 		policy.Deny("iam:organization:delete"),
 	).WithDescription("Full access except organization deletion")
 
 	// Define a self-manage policy - users can manage their own identity
-	selfManagePolicy := policy.NewPolicy("self-manage", "Self Management Policy",
+	selfManagePolicy := policy.NewPolicy(
+		"self-manage",
+		"Self Management Policy",
 		policy.Allow("iam:identity:get", "iam:identity:update").
 			When(policy.Equals("principal.id", "resource.id")),
 	).WithDescription("Users can view and update their own identity")
 
 	// Define a document owner policy - owners can do anything to their documents
-	documentOwnerPolicy := policy.NewPolicy("doc-owner", "Document Owner Policy",
+	documentOwnerPolicy := policy.NewPolicy(
+		"doc-owner",
+		"Document Owner Policy",
 		policy.Allow("documents:document:*").
 			When(policy.Equals("principal.id", "resource.owner_id")),
 	).WithDescription("Document owners have full control over their documents")
@@ -60,11 +68,15 @@ func Example_evaluatingPolicies() {
 	evaluator := policy.NewEvaluator()
 
 	// Define policies
-	viewerPolicy := policy.NewPolicy("viewer", "Viewer",
+	viewerPolicy := policy.NewPolicy(
+		"viewer",
+		"Viewer",
 		policy.Allow("*:*:read", "*:*:list"),
 	)
 
-	adminPolicy := policy.NewPolicy("admin", "Admin",
+	adminPolicy := policy.NewPolicy(
+		"admin",
+		"Admin",
 		policy.Allow("*"),
 		policy.Deny("iam:organization:delete").WithSID("prevent-org-deletion"),
 	)
@@ -119,7 +131,9 @@ func Example_conditionBasedAccess() {
 	evaluator := policy.NewEvaluator()
 
 	// Policy: users can only update their own profile
-	selfManagePolicy := policy.NewPolicy("self-manage", "Self Management",
+	selfManagePolicy := policy.NewPolicy(
+		"self-manage",
+		"Self Management",
 		policy.Allow("iam:identity:update").
 			When(policy.Equals("principal.id", "resource.id")),
 	)