From 13bc57b591d5c87517c67b96447fc9a1dfcffaae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Aur=C3=A9lien=20Sibiril?=
 <81782+aureliensibiril@users.noreply.github.com>
Date: Thu, 4 Jun 2026 19:00:58 +0200
Subject: [PATCH] Drop unused OktaProvider const, wrap parse error
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

OktaProvider was dead: the provider-string const is only matched by
OAuth providers (SlackProvider in oauth2.go / connector.go), and an
API-key connector never matches on it.

Wrap the url.Parse error in nextPageURL with %w, like every sibling
driver, instead of dropping it.

Signed-off-by: Aurélien Sibiril <81782+aureliensibiril@users.noreply.github.com>
---
 pkg/accessreview/drivers/okta.go | 2 +-
 pkg/connector/okta.go            | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/pkg/accessreview/drivers/okta.go b/pkg/accessreview/drivers/okta.go
index 676edd2aa..cc75feef3 100644
--- a/pkg/accessreview/drivers/okta.go
+++ b/pkg/accessreview/drivers/okta.go
@@ -175,7 +175,7 @@ func (d *OktaDriver) nextPageURL(linkHeader string) (string, error) {
 
 	u, err := url.Parse(raw)
 	if err != nil {
-		return "", fmt.Errorf("cannot parse okta next-page link")
+		return "", fmt.Errorf("cannot parse okta next-page link: %w", err)
 	}
 
 	// Pin the next page to the same https origin: reject a scheme downgrade
diff --git a/pkg/connector/okta.go b/pkg/connector/okta.go
index bae857c03..fad6701a1 100644
--- a/pkg/connector/okta.go
+++ b/pkg/connector/okta.go
@@ -22,8 +22,6 @@ import (
 	"strings"
 )
 
-const OktaProvider = "OKTA"
-
 // oktaDomainRe matches a dotted DNS hostname (at least two labels; each
 // label 1-63 chars of [a-z0-9-], not starting or ending with a hyphen).
 // Okta supports both *.okta.com / *.oktapreview.com orgs and fully custom