Share copyFile helper across Unix and Windows updaters
Move the duplicated file-copy logic into update/copy.go so both platform installers stay in sync during maintenance. Signed-off-by: Bryan Frimin <bryan@probo.com>
This commit is contained in:
@@ -18,9 +18,7 @@ package update
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
"io"
|
||||
"os"
|
||||
"path/filepath"
|
||||
)
|
||||
|
||||
// replaceBinary replaces the file at dst with src.
|
||||
@@ -61,41 +59,6 @@ func replaceBinary(dst, src string) error {
|
||||
return nil
|
||||
}
|
||||
|
||||
func copyFile(src, dst string) error {
|
||||
in, err := os.Open(src)
|
||||
if err != nil {
|
||||
return fmt.Errorf("cannot open %s: %w", src, err)
|
||||
}
|
||||
defer func() { _ = in.Close() }()
|
||||
|
||||
if err := os.MkdirAll(filepath.Dir(dst), 0o755); err != nil {
|
||||
return fmt.Errorf("cannot ensure %s: %w", filepath.Dir(dst), err)
|
||||
}
|
||||
|
||||
out, err := os.OpenFile(dst, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0o755)
|
||||
if err != nil {
|
||||
return fmt.Errorf("cannot create %s: %w", dst, err)
|
||||
}
|
||||
|
||||
if _, err := io.Copy(out, in); err != nil {
|
||||
_ = out.Close()
|
||||
_ = os.Remove(dst)
|
||||
return fmt.Errorf("cannot copy to %s: %w", dst, err)
|
||||
}
|
||||
if err := out.Sync(); err != nil {
|
||||
_ = out.Close()
|
||||
_ = os.Remove(dst)
|
||||
return fmt.Errorf("cannot fsync %s: %w", dst, err)
|
||||
}
|
||||
|
||||
if err := out.Close(); err != nil {
|
||||
_ = os.Remove(dst)
|
||||
return fmt.Errorf("cannot close %s: %w", dst, err)
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
// CleanupAfterRestart removes any leftover .old binary from a
|
||||
// previous Windows-style swap. On Unix this is a no-op.
|
||||
func CleanupAfterRestart(_ string) {}
|
||||
|
||||
Reference in New Issue
Block a user