rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor LLM config into top-level settings

Browse Source 
Replace the monolithic agents config with a cleaner structure:
- llm: holds provider credentials and default model settings
- probo-agent: LLM overrides for the probo agent
- evidence-describer: worker config (interval, stale-after,
  max-concurrency) alongside LLM overrides

This makes worker tuning configurable via YAML and env vars
instead of being hardcoded in Go, and separates provider
credentials from per-consumer model settings.

Signed-off-by: Bryan Frimin <bryan@getprobo.com>
This commit is contained in:
Bryan Frimin
2026-03-27 07:48:43 +01:00
committed by Sacha Al Himdani
parent 0926a8828a
commit 050154ab6a
6 changed files with 179 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

98
pkg/bootstrap/builder_test.go
View File

@@ -161,20 +161,25 @@ func TestBuilder_Build_Defaults(t *testing.T) {
assert.Equal(t, 5, cfg.Probod.Notifications.Webhook.SenderInterval)
assert.Equal(t, 86400, cfg.Probod.Notifications.Webhook.CacheTTL)
// Agents config — default
assert.Equal(t, "openai", cfg.Probod.Agents.Default.Provider)
assert.Equal(t, "gpt-4o", cfg.Probod.Agents.Default.ModelName)
assert.Equal(t, new(0.1), cfg.Probod.Agents.Default.Temperature)
assert.Equal(t, new(4096), cfg.Probod.Agents.Default.MaxTokens)
// Agents config — per-agent overrides are empty (inherit from default)
assert.Empty(t, cfg.Probod.Agents.Probo.Provider)
assert.Empty(t, cfg.Probod.Agents.Probo.ModelName)
assert.Nil(t, cfg.Probod.Agents.Probo.Temperature)
assert.Nil(t, cfg.Probod.Agents.Probo.MaxTokens)
assert.Empty(t, cfg.Probod.Agents.EvidenceDescriber.Provider)
assert.Empty(t, cfg.Probod.Agents.EvidenceDescriber.ModelName)
assert.Nil(t, cfg.Probod.Agents.EvidenceDescriber.Temperature)
assert.Nil(t, cfg.Probod.Agents.EvidenceDescriber.MaxTokens)
// LLM config — defaults
assert.Equal(t, "openai", cfg.Probod.LLM.Defaults.Provider)
assert.Equal(t, "gpt-4o", cfg.Probod.LLM.Defaults.ModelName)
assert.Equal(t, new(0.1), cfg.Probod.LLM.Defaults.Temperature)
assert.Equal(t, new(4096), cfg.Probod.LLM.Defaults.MaxTokens)
// Probo agent — empty (inherits from defaults)
assert.Empty(t, cfg.Probod.ProboAgent.Provider)
assert.Empty(t, cfg.Probod.ProboAgent.ModelName)
assert.Nil(t, cfg.Probod.ProboAgent.Temperature)
assert.Nil(t, cfg.Probod.ProboAgent.MaxTokens)
// Evidence describer — LLM fields empty (inherits from defaults)
assert.Empty(t, cfg.Probod.EvidenceDescriber.Provider)
assert.Empty(t, cfg.Probod.EvidenceDescriber.ModelName)
assert.Nil(t, cfg.Probod.EvidenceDescriber.Temperature)
assert.Nil(t, cfg.Probod.EvidenceDescriber.MaxTokens)
// Evidence describer — worker defaults
assert.Equal(t, 10, cfg.Probod.EvidenceDescriber.Interval)
assert.Equal(t, 300, cfg.Probod.EvidenceDescriber.StaleAfter)
assert.Equal(t, 10, cfg.Probod.EvidenceDescriber.MaxConcurrency)
// Custom domains config
assert.Equal(t, 3600, cfg.Probod.CustomDomains.RenewalInterval)
@@ -241,19 +246,22 @@ func TestBuilder_Build_CustomValues(t *testing.T) {
env["WEBHOOK_SENDER_INTERVAL"] = "10"
env["WEBHOOK_CACHE_TTL"] = "3600"
env["CONNECTOR_SLACK_SIGNING_SECRET"] = "slack-signing-secret"
// Agents — providers
// LLM — providers
env["OPENAI_API_KEY"] = "sk-test-key"
env["ANTHROPIC_API_KEY"] = "sk-ant-test-key"
// Agents — default
env["AGENT_DEFAULT_PROVIDER"] = "openai"
env["AGENT_DEFAULT_MODEL_NAME"] = "gpt-4-turbo"
env["AGENT_DEFAULT_TEMPERATURE"] = "0.5"
env["AGENT_DEFAULT_MAX_TOKENS"] = "8192"
// Agents — evidence-describer override
env["AGENT_EVIDENCE_DESCRIBER_PROVIDER"] = "anthropic"
env["AGENT_EVIDENCE_DESCRIBER_MODEL_NAME"] = "claude-sonnet-4-20250514"
env["AGENT_EVIDENCE_DESCRIBER_TEMPERATURE"] = "0.2"
env["AGENT_EVIDENCE_DESCRIBER_MAX_TOKENS"] = "4096"
// LLM — defaults
env["LLM_DEFAULT_PROVIDER"] = "openai"
env["LLM_DEFAULT_MODEL_NAME"] = "gpt-4-turbo"
env["LLM_DEFAULT_TEMPERATURE"] = "0.5"
env["LLM_DEFAULT_MAX_TOKENS"] = "8192"
// Evidence describer
env["EVIDENCE_DESCRIBER_PROVIDER"] = "anthropic"
env["EVIDENCE_DESCRIBER_MODEL_NAME"] = "claude-sonnet-4-20250514"
env["EVIDENCE_DESCRIBER_TEMPERATURE"] = "0.2"
env["EVIDENCE_DESCRIBER_MAX_TOKENS"] = "4096"
env["EVIDENCE_DESCRIBER_INTERVAL"] = "15"
env["EVIDENCE_DESCRIBER_STALE_AFTER"] = "600"
env["EVIDENCE_DESCRIBER_MAX_CONCURRENCY"] = "20"
// Custom domains
env["CUSTOM_DOMAINS_RESOLVER_ADDR"] = "1.1.1.1:53"
env["ACME_ACCOUNT_KEY"] = "-----BEGIN EC PRIVATE KEY-----\ntest\n-----END EC PRIVATE KEY-----"
@@ -313,24 +321,28 @@ func TestBuilder_Build_CustomValues(t *testing.T) {
assert.Equal(t, "slack-signing-secret", cfg.Probod.Notifications.Slack.SigningSecret)
assert.Equal(t, 10, cfg.Probod.Notifications.Webhook.SenderInterval)
assert.Equal(t, 3600, cfg.Probod.Notifications.Webhook.CacheTTL)
// Agents — providers
assert.Equal(t, "openai", cfg.Probod.Agents.Providers["openai"].Type)
assert.Equal(t, "sk-test-key", cfg.Probod.Agents.Providers["openai"].APIKey)
assert.Equal(t, "anthropic", cfg.Probod.Agents.Providers["anthropic"].Type)
assert.Equal(t, "sk-ant-test-key", cfg.Probod.Agents.Providers["anthropic"].APIKey)
// Agents — default
assert.Equal(t, "openai", cfg.Probod.Agents.Default.Provider)
assert.Equal(t, "gpt-4-turbo", cfg.Probod.Agents.Default.ModelName)
assert.Equal(t, new(0.5), cfg.Probod.Agents.Default.Temperature)
assert.Equal(t, new(8192), cfg.Probod.Agents.Default.MaxTokens)
// Agents — probo inherits default (no overrides set)
assert.Empty(t, cfg.Probod.Agents.Probo.Provider)
assert.Empty(t, cfg.Probod.Agents.Probo.ModelName)
// Agents — evidence-describer overrides
assert.Equal(t, "anthropic", cfg.Probod.Agents.EvidenceDescriber.Provider)
assert.Equal(t, "claude-sonnet-4-20250514", cfg.Probod.Agents.EvidenceDescriber.ModelName)
assert.Equal(t, new(0.2), cfg.Probod.Agents.EvidenceDescriber.Temperature)
assert.Equal(t, new(4096), cfg.Probod.Agents.EvidenceDescriber.MaxTokens)
// LLM — providers
assert.Equal(t, "openai", cfg.Probod.LLM.Providers["openai"].Type)
assert.Equal(t, "sk-test-key", cfg.Probod.LLM.Providers["openai"].APIKey)
assert.Equal(t, "anthropic", cfg.Probod.LLM.Providers["anthropic"].Type)
assert.Equal(t, "sk-ant-test-key", cfg.Probod.LLM.Providers["anthropic"].APIKey)
// LLM — defaults
assert.Equal(t, "openai", cfg.Probod.LLM.Defaults.Provider)
assert.Equal(t, "gpt-4-turbo", cfg.Probod.LLM.Defaults.ModelName)
assert.Equal(t, new(0.5), cfg.Probod.LLM.Defaults.Temperature)
assert.Equal(t, new(8192), cfg.Probod.LLM.Defaults.MaxTokens)
// Probo agent — inherits defaults (no overrides set)
assert.Empty(t, cfg.Probod.ProboAgent.Provider)
assert.Empty(t, cfg.Probod.ProboAgent.ModelName)
// Evidence describer — LLM overrides
assert.Equal(t, "anthropic", cfg.Probod.EvidenceDescriber.Provider)
assert.Equal(t, "claude-sonnet-4-20250514", cfg.Probod.EvidenceDescriber.ModelName)
assert.Equal(t, new(0.2), cfg.Probod.EvidenceDescriber.Temperature)
assert.Equal(t, new(4096), cfg.Probod.EvidenceDescriber.MaxTokens)
// Evidence describer — worker config
assert.Equal(t, 15, cfg.Probod.EvidenceDescriber.Interval)
assert.Equal(t, 600, cfg.Probod.EvidenceDescriber.StaleAfter)
assert.Equal(t, 20, cfg.Probod.EvidenceDescriber.MaxConcurrency)
// Custom domains
assert.Equal(t, "1.1.1.1:53", cfg.Probod.CustomDomains.ResolverAddr)
assert.Equal(t, "-----BEGIN EC PRIVATE KEY-----\ntest\n-----END EC PRIVATE KEY-----", cfg.Probod.CustomDomains.ACME.AccountKey)