Fix TextLength to count characters instead of bytes

Use utf8.RuneCountInString so multi-byte characters like é count as one
character. Add a unicode test case to cover this.

Signed-off-by: Émile Ré <emile@getprobo.com>
This commit is contained in:
Émile Ré
2026-04-09 13:39:39 +04:00
parent 7cd4606278
commit 050073ab3c
2 changed files with 15 additions and 4 deletions

View File

@@ -17,6 +17,7 @@ package prosemirror
import ( import (
"encoding/json" "encoding/json"
"fmt" "fmt"
"unicode/utf8"
) )
type ( type (
@@ -168,13 +169,12 @@ func (n Node) TableCellAttrs() (TableCellAttrs, error) {
return a, nil return a, nil
} }
// TextLength returns the total length of all text content in the node tree, // TextLength returns the total number of characters (Unicode code points)
// measured in bytes (consistent with Go's len on strings). Only text carried // across all text nodes in the tree. Structural markup is excluded.
// by leaf text nodes is counted; structural markup is excluded.
func (n Node) TextLength() int { func (n Node) TextLength() int {
length := 0 length := 0
if n.Text != nil { if n.Text != nil {
length += len(*n.Text) length += utf8.RuneCountInString(*n.Text)
} }
for _, child := range n.Content { for _, child := range n.Content {
length += child.TextLength() length += child.TextLength()

View File

@@ -487,6 +487,17 @@ func TestTextLength(t *testing.T) {
}, },
) )
t.Run(
"multi-byte unicode characters",
func(t *testing.T) {
t.Parallel()
raw := `{"type":"doc","content":[{"type":"paragraph","content":[{"type":"text","text":"café résumé"}]}]}`
doc, err := Parse(raw)
require.NoError(t, err)
assert.Equal(t, 11, doc.TextLength())
},
)
t.Run( t.Run(
"testdata document", "testdata document",
func(t *testing.T) { func(t *testing.T) {