rohit/probo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use panic instead of returning errors in resolvers

Browse Source 
Signed-off-by: Sacha Al Himdani <sacha@getprobo.com>
This commit is contained in:
Sacha Al Himdani
2025-09-03 12:18:00 +02:00
parent d3f99774e5
commit 018580c1db
2 changed files with 33 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
pkg/server/api/console/v1/v1_resolver.go
View File

@@ -81,12 +81,12 @@ func (r *assetResolver) Organization(ctx context.Context, obj *types.Asset) (*ty
prb := r.ProboService(ctx, obj.ID.TenantID()) prb := r.ProboService(ctx, obj.ID.TenantID())
if obj.Organization == nil { if obj.Organization == nil {
return nil, fmt.Errorf("cannot get organization") panic(fmt.Errorf("cannot get organization"))
} }
org, err := prb.Organizations.Get(ctx, obj.Organization.ID) org, err := prb.Organizations.Get(ctx, obj.Organization.ID)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot get organization: %w", err) panic(fmt.Errorf("cannot get organization: %w", err))
} }
return types.NewOrganization(org), nil return types.NewOrganization(org), nil
@@ -105,7 +105,7 @@ func (r *assetConnectionResolver) TotalCount(ctx context.Context, obj *types.Ass
count, err := prb.Assets.CountForOrganizationID(ctx, obj.ParentID, assetFilter) count, err := prb.Assets.CountForOrganizationID(ctx, obj.ParentID, assetFilter)
if err != nil { if err != nil {
return 0, fmt.Errorf("cannot count assets: %w", err) panic(fmt.Errorf("cannot count assets: %w", err))
} }
return count, nil return count, nil
} }
@@ -119,12 +119,12 @@ func (r *auditResolver) Organization(ctx context.Context, obj *types.Audit) (*ty
audit, err := prb.Audits.Get(ctx, obj.ID) audit, err := prb.Audits.Get(ctx, obj.ID)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot load audit: %w", err) panic(fmt.Errorf("cannot load audit: %w", err))
} }
organization, err := prb.Organizations.Get(ctx, audit.OrganizationID) organization, err := prb.Organizations.Get(ctx, audit.OrganizationID)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot load organization: %w", err) panic(fmt.Errorf("cannot load organization: %w", err))
} }
return types.NewOrganization(organization), nil return types.NewOrganization(organization), nil
@@ -136,12 +136,12 @@ func (r *auditResolver) Framework(ctx context.Context, obj *types.Audit) (*types
audit, err := prb.Audits.Get(ctx, obj.ID) audit, err := prb.Audits.Get(ctx, obj.ID)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot load audit: %w", err) panic(fmt.Errorf("cannot load audit: %w", err))
} }
framework, err := prb.Frameworks.Get(ctx, audit.FrameworkID) framework, err := prb.Frameworks.Get(ctx, audit.FrameworkID)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot load framework: %w", err) panic(fmt.Errorf("cannot load framework: %w", err))
} }
return types.NewFramework(framework), nil return types.NewFramework(framework), nil
@@ -153,7 +153,7 @@ func (r *auditResolver) Report(ctx context.Context, obj *types.Audit) (*types.Re
audit, err := prb.Audits.Get(ctx, obj.ID) audit, err := prb.Audits.Get(ctx, obj.ID)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot load audit: %w", err) panic(fmt.Errorf("cannot load audit: %w", err))
} }
if audit.ReportID == nil { if audit.ReportID == nil {
@@ -162,7 +162,7 @@ func (r *auditResolver) Report(ctx context.Context, obj *types.Audit) (*types.Re
report, err := prb.Reports.Get(ctx, *audit.ReportID) report, err := prb.Reports.Get(ctx, *audit.ReportID)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot load report: %w", err) panic(fmt.Errorf("cannot load report: %w", err))
} }
return types.NewReport(report), nil return types.NewReport(report), nil
@@ -178,7 +178,7 @@ func (r *auditResolver) ReportURL(ctx context.Context, obj *types.Audit) (*strin
url, err := prb.Audits.GenerateReportURL(ctx, obj.ID, 15*time.Minute) url, err := prb.Audits.GenerateReportURL(ctx, obj.ID, 15*time.Minute)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot generate report URL: %w", err) panic(fmt.Errorf("cannot generate report URL: %w", err))
} }
return url, nil return url, nil
@@ -208,7 +208,7 @@ func (r *auditResolver) Controls(ctx context.Context, obj *types.Audit, first *i
page, err := prb.Controls.ListForAuditID(ctx, obj.ID, cursor, controlFilter) page, err := prb.Controls.ListForAuditID(ctx, obj.ID, cursor, controlFilter)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot list audit controls: %w", err) panic(fmt.Errorf("cannot list audit controls: %w", err))
} }
return types.NewControlConnection(page, r, obj.ID, controlFilter), nil return types.NewControlConnection(page, r, obj.ID, controlFilter), nil
@@ -220,7 +220,7 @@ func (r *auditConnectionResolver) TotalCount(ctx context.Context, obj *types.Aud
count, err := prb.Audits.CountForOrganizationID(ctx, obj.ParentID) count, err := prb.Audits.CountForOrganizationID(ctx, obj.ParentID)
if err != nil { if err != nil {
return 0, fmt.Errorf("cannot count audits: %w", err) panic(fmt.Errorf("cannot count audits: %w", err))
} }
return count, nil return count, nil
} }
@@ -3898,7 +3898,7 @@ func (r *peopleConnectionResolver) TotalCount(ctx context.Context, obj *types.Pe
case *organizationResolver: case *organizationResolver:
count, err := prb.Peoples.CountForOrganizationID(ctx, obj.ParentID, obj.Filters) count, err := prb.Peoples.CountForOrganizationID(ctx, obj.ParentID, obj.Filters)
if err != nil { if err != nil {
return 0, fmt.Errorf("cannot count peoples: %w", err) panic(fmt.Errorf("cannot count peoples: %w", err))
} }
return count, nil return count, nil
} }
@@ -4130,7 +4130,7 @@ func (r *reportResolver) DownloadURL(ctx context.Context, obj *types.Report) (*s
url, err := prb.Reports.GenerateDownloadURL(ctx, obj.ID, 15*time.Minute) url, err := prb.Reports.GenerateDownloadURL(ctx, obj.ID, 15*time.Minute)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot generate download URL: %w", err) panic(fmt.Errorf("cannot generate download URL: %w", err))
} }
return url, nil return url, nil
@@ -4435,13 +4435,13 @@ func (r *taskConnectionResolver) TotalCount(ctx context.Context, obj *types.Task
case *measureResolver: case *measureResolver:
count, err := prb.Tasks.CountForMeasureID(ctx, obj.ParentID) count, err := prb.Tasks.CountForMeasureID(ctx, obj.ParentID)
if err != nil { if err != nil {
return 0, fmt.Errorf("cannot count tasks: %w", err) panic(fmt.Errorf("cannot count tasks: %w", err))
} }
return count, nil return count, nil
case *organizationResolver: case *organizationResolver:
count, err := prb.Tasks.CountForOrganizationID(ctx, obj.ParentID) count, err := prb.Tasks.CountForOrganizationID(ctx, obj.ParentID)
if err != nil { if err != nil {
return 0, fmt.Errorf("cannot count tasks: %w", err) panic(fmt.Errorf("cannot count tasks: %w", err))
} }
return count, nil return count, nil
} }
@@ -4455,7 +4455,7 @@ func (r *trustCenterResolver) Organization(ctx context.Context, obj *types.Trust
organization, err := prb.Organizations.Get(ctx, obj.Organization.ID) organization, err := prb.Organizations.Get(ctx, obj.Organization.ID)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot get organization: %w", err) panic(fmt.Errorf("cannot get organization: %w", err))
} }
return types.NewOrganization(organization), nil return types.NewOrganization(organization), nil
@@ -4550,7 +4550,7 @@ func (r *vendorResolver) BusinessAssociateAgreement(ctx context.Context, obj *ty
return nil, nil return nil, nil
} }
return nil, fmt.Errorf("failed to get vendor business associate agreement: %w", err) panic(fmt.Errorf("failed to get vendor business associate agreement: %w", err))
} }
return types.NewVendorBusinessAssociateAgreement(vendorBusinessAssociateAgreement, file), nil return types.NewVendorBusinessAssociateAgreement(vendorBusinessAssociateAgreement, file), nil
@@ -4566,7 +4566,7 @@ func (r *vendorResolver) DataPrivacyAgreement(ctx context.Context, obj *types.Ve
return nil, nil return nil, nil
} }
return nil, fmt.Errorf("failed to get vendor data privacy agreement: %w", err) panic(fmt.Errorf("failed to get vendor data privacy agreement: %w", err))
} }
return types.NewVendorDataPrivacyAgreement(vendorDataPrivacyAgreement, file), nil return types.NewVendorDataPrivacyAgreement(vendorDataPrivacyAgreement, file), nil
@@ -4744,19 +4744,19 @@ func (r *vendorConnectionResolver) TotalCount(ctx context.Context, obj *types.Ve
case *organizationResolver: case *organizationResolver:
count, err := prb.Vendors.CountForOrganizationID(ctx, obj.ParentID) count, err := prb.Vendors.CountForOrganizationID(ctx, obj.ParentID)
if err != nil { if err != nil {
return 0, fmt.Errorf("cannot count vendors: %w", err) panic(fmt.Errorf("cannot count vendors: %w", err))
} }
return count, nil return count, nil
case *assetResolver: case *assetResolver:
count, err := prb.Vendors.CountForAssetID(ctx, obj.ParentID) count, err := prb.Vendors.CountForAssetID(ctx, obj.ParentID)
if err != nil { if err != nil {
return 0, fmt.Errorf("cannot count vendors: %w", err) panic(fmt.Errorf("cannot count vendors: %w", err))
} }
return count, nil return count, nil
case *datumResolver: case *datumResolver:
count, err := prb.Vendors.CountForDatumID(ctx, obj.ParentID) count, err := prb.Vendors.CountForDatumID(ctx, obj.ParentID)
if err != nil { if err != nil {
return 0, fmt.Errorf("cannot count vendors: %w", err) panic(fmt.Errorf("cannot count vendors: %w", err))
} }
return count, nil return count, nil
} }
@@ -4788,7 +4788,7 @@ func (r *vendorDataPrivacyAgreementResolver) Vendor(ctx context.Context, obj *ty
vendor, err := prb.Vendors.Get(ctx, obj.ID) vendor, err := prb.Vendors.Get(ctx, obj.ID)
if err != nil { if err != nil {
return nil, fmt.Errorf("failed to get vendor: %w", err) panic(fmt.Errorf("failed to get vendor: %w", err))
} }
return types.NewVendor(vendor), nil return types.NewVendor(vendor), nil
@@ -4800,7 +4800,7 @@ func (r *vendorDataPrivacyAgreementResolver) FileURL(ctx context.Context, obj *t
fileURL, err := prb.VendorDataPrivacyAgreements.GenerateFileURL(ctx, obj.ID, 1*time.Hour) fileURL, err := prb.VendorDataPrivacyAgreements.GenerateFileURL(ctx, obj.ID, 1*time.Hour)
if err != nil { if err != nil {
return "", fmt.Errorf("failed to generate file URL: %w", err) panic(fmt.Errorf("failed to generate file URL: %w", err))
} }
return fileURL, nil return fileURL, nil

18
pkg/server/api/trust/v1/v1_resolver.go
View File

@@ -25,12 +25,12 @@ func (r *auditResolver) Framework(ctx context.Context, obj *types.Audit) (*types
audit, err := trust.Audits.Get(ctx, obj.ID) audit, err := trust.Audits.Get(ctx, obj.ID)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot load audit: %w", err) panic(fmt.Errorf("cannot load audit: %w", err))
} }
framework, err := trust.Frameworks.Get(ctx, audit.FrameworkID) framework, err := trust.Frameworks.Get(ctx, audit.FrameworkID)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot load framework: %w", err) panic(fmt.Errorf("cannot load framework: %w", err))
} }
return types.NewFramework(framework), nil return types.NewFramework(framework), nil
@@ -42,7 +42,7 @@ func (r *auditResolver) Report(ctx context.Context, obj *types.Audit) (*types.Re
audit, err := trust.Audits.Get(ctx, obj.ID) audit, err := trust.Audits.Get(ctx, obj.ID)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot load audit: %w", err) panic(fmt.Errorf("cannot load audit: %w", err))
} }
if audit.ReportID == nil { if audit.ReportID == nil {
@@ -51,7 +51,7 @@ func (r *auditResolver) Report(ctx context.Context, obj *types.Audit) (*types.Re
report, err := trust.Reports.Get(ctx, *audit.ReportID) report, err := trust.Reports.Get(ctx, *audit.ReportID)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot load report: %w", err) panic(fmt.Errorf("cannot load report: %w", err))
} }
return types.NewReport(report), nil return types.NewReport(report), nil
@@ -124,7 +124,7 @@ func (r *queryResolver) TrustCenterBySlug(ctx context.Context, slug string) (*ty
orgTrust := r.trustCenterSvc.WithTenant(trustCenter.TenantID) orgTrust := r.trustCenterSvc.WithTenant(trustCenter.TenantID)
org, err := orgTrust.Organizations.Get(ctx, trustCenter.OrganizationID) org, err := orgTrust.Organizations.Get(ctx, trustCenter.OrganizationID)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot get organization: %w", err) panic(fmt.Errorf("cannot get organization: %w", err))
} }
result.Organization = types.NewOrganization(org) result.Organization = types.NewOrganization(org)
@@ -142,7 +142,7 @@ func (r *reportResolver) DownloadURL(ctx context.Context, obj *types.Report) (*s
url, err := trust.Reports.GenerateDownloadURL(ctx, obj.ID, r.trustAuthCfg.ReportURLDuration) url, err := trust.Reports.GenerateDownloadURL(ctx, obj.ID, r.trustAuthCfg.ReportURLDuration)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot generate download URL: %w", err) panic(fmt.Errorf("cannot generate download URL: %w", err))
} }
return url, nil return url, nil
@@ -173,7 +173,7 @@ func (r *trustCenterResolver) Documents(ctx context.Context, obj *types.TrustCen
documentPage, err := trust.Documents.ListForOrganizationId(ctx, obj.Organization.ID, cursor) documentPage, err := trust.Documents.ListForOrganizationId(ctx, obj.Organization.ID, cursor)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot list public documents: %w", err) panic(fmt.Errorf("cannot list public documents: %w", err))
} }
return types.NewDocumentConnection(documentPage), nil return types.NewDocumentConnection(documentPage), nil
@@ -191,7 +191,7 @@ func (r *trustCenterResolver) Audits(ctx context.Context, obj *types.TrustCenter
auditPage, err := trust.Audits.ListForOrganizationId(ctx, obj.Organization.ID, cursor) auditPage, err := trust.Audits.ListForOrganizationId(ctx, obj.Organization.ID, cursor)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot list public audits: %w", err) panic(fmt.Errorf("cannot list public audits: %w", err))
} }
return types.NewAuditConnection(auditPage), nil return types.NewAuditConnection(auditPage), nil
@@ -209,7 +209,7 @@ func (r *trustCenterResolver) Vendors(ctx context.Context, obj *types.TrustCente
vendorPage, err := trust.Vendors.ListForOrganizationId(ctx, obj.Organization.ID, cursor) vendorPage, err := trust.Vendors.ListForOrganizationId(ctx, obj.Organization.ID, cursor)
if err != nil { if err != nil {
return nil, fmt.Errorf("cannot list public vendors: %w", err) panic(fmt.Errorf("cannot list public vendors: %w", err))
} }
return types.NewVendorConnection(vendorPage), nil return types.NewVendorConnection(vendorPage), nil